Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error codes to refresh token flow #1824

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Oct 30, 2024

What kind of change does this PR introduce?

  • Updates the refresh token flow to use error codes
  • The oauthError originally returns a bad request error (400) so we're keeping the status codes the same in this PR.
  • Once this is merged, we can update the client lib to start picking up on these new error codes and removing the session locally.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11598437586

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • 18 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 57.035%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/token.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/api/errors.go 18 63.51%
Totals Coverage Status
Change from base Build 11595332069: -0.1%
Covered Lines: 9546
Relevant Lines: 16737

💛 - Coveralls

@kangmingtay kangmingtay merged commit 4614dc5 into master Nov 1, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/add-error-codes branch November 1, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants